Hi David, thanks for the reply. I'm not sure if I am making my photos dark. I do generally need to brighten my photos in PP to make them a bit punchier. So either I'm a really bad photographer or what you have suggested is not it. Besides when I watch films or videos on my monitor, they are nowhere near as dark as the prints. Also, my photos look ok on my monitor, my parents laptop and my work monitor. I know none of them are calibrated, but they all look roughly the same and nowhere near the prints. The prints are very dark.
I'm not sure about the yellow. I don't adjust individual colours in PP. I'll have a look in Photoshop.
I did try a local camera club last year, but after two meetings I got the general idea that no one there has heard of digital photography, as they was all film users. At 36 I was the youngest there by a very long way. I gave up after two meetings.
I've just had a quick look at the calibration devices you've mentioned. Any particular version of each? The Spyder3 looks good price wise, but would I need the Pro version or would the more basic version alright? Sorry I know nothing about this sort of thing. If in doubt with things, I usually just go for the better version of things, but I'm not sure if the Pro version would be overkill for home hobby use?