yea, calton hill is a definite go-to location, and be sure to walk around the hill as there are a lot of different angles on to the city; arthurs seat is very good as well (although tbh, you might be better just walking up the nearby crags and parkland rather than hiking to the very top...